Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

Upgrade gaffer-tools to build with Java 8 and Java 11 #850

Closed
t11947 opened this issue Aug 5, 2020 · 7 comments · Fixed by #995
Closed

Upgrade gaffer-tools to build with Java 8 and Java 11 #850

t11947 opened this issue Aug 5, 2020 · 7 comments · Fixed by #995

Comments

@t11947
Copy link
Contributor

t11947 commented Aug 5, 2020

This issue has been rescoped to add a feature not in #995

@GCHQDeveloper314 said: "It was decided that the POM for Gaffer Tools should have a Java 11 profile to automatically create Java 11 code when a Suitable version of the JDK is used - the same as exists in Gaffer. This should be straightforward to do and will be done as part of the next release."

@t11947 t11947 added the p:high label Aug 5, 2020
@t11947
Copy link
Contributor Author

t11947 commented Aug 20, 2020

Edited ticket to remove modularisation from the scope.

@n3101 n3101 added this to the v2.0.0 milestone May 18, 2021
@n3101 n3101 modified the milestones: v2.0.0, v2.0.0-alpha-0.2 Jan 26, 2022
@GCHQDeveloper314
Copy link
Member

The work required for the Java 11 upgrade has been drafted in the gh-850-java11 branch. Not many changes were required beyond removing use of deprecated functionality that is removed in Gaffer v2. There is a problem with the slider module which relies on the Apache Slider project. This project has been retired and hasn't been updated since March 2017. It is unable to work with recent versions of Hadoop/Accumulo. At least some functionality from Slider has been merged into Hadoop YARN. A decision needs to be taken about Slider as this blocks any upgrade to version 2.

@GCHQDeveloper314
Copy link
Member

The changes in Gaffer itself and in #995 are sufficient for Gaffer Tools to build with Java 11.

@GCHQDeveloper314 GCHQDeveloper314 linked a pull request Apr 8, 2022 that will close this issue
@n3101
Copy link

n3101 commented May 4, 2022

@t92549 Given the comment above: "The changes in Gaffer itself and in #995 are sufficient for Gaffer Tools to build with Java 11.", is this issue now complete?

@GCHQDeveloper314
Copy link
Member

It was decided that the POM for Gaffer Tools should have a Java 11 profile to automatically create Java 11 code when a Suitable version of the JDK is used - the same as exists in Gaffer. This should be straightforward to do and will be done as part of the next release.

@n3101 n3101 changed the title Upgrade to Java 11 Add Java 11 profile May 4, 2022
@GCHQDeveloper314
Copy link
Member

GCHQDeveloper314 commented May 5, 2022

In fact, we don't need to add a Java 11 profile. The profile from Gaffer which enables Java 11 is inherited though the Gaffer POM and is now automatically used in Gaffer Tools. No further work is therefore required to add a profile to Gaffer Tools. This profile has been tested and Gaffer Tools is working correctly with Java 11. This issue can now be closed.

@t92549 t92549 changed the title Add Java 11 profile Upgrade gaffer-tools to build with Java 8 and Java 11 May 5, 2022
@t92549
Copy link
Contributor

t92549 commented May 5, 2022

In fact, we don't need to add a Java 11 profile. The profile from Gaffer which enables Java 11 is inherited though the Gaffer POM and is now automatically used in Gaffer Tools. No further work is therefore required to add a profile to Gaffer Tools. This profile has been tested and Gaffer Tools is working correctly with Java 11. This issue can now be closed.

This issue has been retroactively added to the alpha 2 release notes as it is a new feature that was enabled by upgrading tools to work with alpha 2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants