Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: base58 encoding ignored heading zero bytes #380

Closed
ghost opened this issue Oct 10, 2018 · 1 comment
Closed

Bug report: base58 encoding ignored heading zero bytes #380

ghost opened this issue Oct 10, 2018 · 1 comment
Labels
bug help wanted

Comments

@ghost
Copy link

ghost commented Oct 10, 2018 •
edited by ghost
Loading

Summary

base58 encoding for [0x00, 0x12, 0x34] is same as [0x12, 0x34]

Example

https://gchq.github.io/CyberChef/#recipe=From_Hex('None')To_Base58('123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz')&input=MDAxMjM0

https://gchq.github.io/CyberChef/#recipe=From_Hex('None')To_Base58('123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz')&input=MTIzNA

>>> base58.b58encode("001234".decode('hex'))
'12PM'
>>> base58.b58encode("1234".decode('hex'))
'2PM'
@bwhitn bwhitn mentioned this issue Oct 22, 2018
Merged
@n1474335
Copy link
Member

n1474335 commented Nov 6, 2018

Fixed in #403. Thanks to @bwhitn.

@n1474335 n1474335 closed this as completed Nov 6, 2018
@Croat79 Croat79 mentioned this issue Oct 25, 2023
Open
@rx007 rx007 mentioned this issue Oct 25, 2023
Open
@ekmixon ekmixon mentioned this issue Oct 25, 2023
Open
@sergiogval sergiogval mentioned this issue Oct 26, 2023
Open
@masifpak masifpak mentioned this issue Oct 26, 2023
Open
@deepcodeg deepcodeg mentioned this issue Oct 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@n1474335