Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report: Disabled options get enabled again when changing something in the recipe #247

Closed
InsOpDe opened this issue Mar 1, 2018 · 3 comments
Labels

Comments

@InsOpDe
Copy link

InsOpDe commented Mar 1, 2018

  • Version: 7.7.6
  • Compile time: 28/02/2018 18:01:49 UTC
  • User-Agent:
    Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/64.0.3282.167 Chrome/64.0.3282.167 Safari/537.36
  • Link to reproduce

Summary

When disabling/enabling a "operation a" the disabled options of "operation b" gets enabled again.
Its important that the options of "operation b" once where enabled before for this to reproduce.
This is confirmed with "From Base64" and "Find / Replace" but is most likely a bug for each operation with checkbox-options

Example

cyberchef

@InsOpDe InsOpDe changed the title Disabled options get enabled again when changing something in the recipe Bug report: Disabled options get enabled again when changing something in the recipe Mar 1, 2018
@n1474335 n1474335 added the bug label Mar 1, 2018
@n1474335
Copy link
Member

n1474335 commented Mar 1, 2018

Yes, this has been a problem for some time. It's a known bug in the Sortable library that I use for the drag and drop capabilities.

More info here: SortableJS/Sortable#1052

Once it has been fixed, I will update the dependency.

@GCHQ77703
Copy link
Member

RubaXa seems to no longer maintain Sortable. The fix for this is, however, on the master branch of the Github repository.

Would it be worthwhile to fork it and release the latest verison to npm ourselves?

@n1474335
Copy link
Member

n1474335 commented Jan 7, 2019

This has been fixed in SortableJS v1.8.0-rc1 which we use as of d469fb9#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R124

@n1474335 n1474335 closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants