Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific minimal subset of JSKOS API #171

Open
nichtich opened this issue Apr 29, 2022 · 3 comments
Open

Specific minimal subset of JSKOS API #171

nichtich opened this issue Apr 29, 2022 · 3 comments
Labels
documentation Provide sufficient documentation question Further information is requested
Milestone

Comments

@nichtich
Copy link
Member

Which endpoints and query parameters must be supported to

  • provide a vocabulary
  • provide mappings

In addition to wikidata-jskos there will be an implementation of subset of JSKOS API for Konstanz Systematics so definition of what to expect would be helpful.

@nichtich nichtich added the documentation Provide sufficient documentation label Apr 29, 2022
@nichtich
Copy link
Member Author

The subset for vocabularies and concepts ist most relevant. To do so add API endpoints:

  • alias /narrower as /voc/narrower and make the second the primary, the first deprecated
  • alias /ancestors as/voc/ancestors and make the second the primary, the first deprecated

And then specify a subset of API endpoints /voc* as JSKOS Vocabulary API. API perameters should be reduced too, e.g. make support of properties optional.

@nichtich nichtich added the question Further information is requested label Dec 14, 2022
@stefandesu
Copy link
Member

I just noticed that /voc/narrower//voc/ancestors are not consistent with other endpoints, considering your suggestions in #189. From my point of view, it should be /voc/concepts/narrower//voc/concepts/ancestors, right? Maybe it would be better to have vocabulary data under /voc*, but concept data under /concepts*? We also have /search and /suggest which are concept endpoints, so we would have /concepts/search for concept search and /voc/search for vocabulary search.

@stefandesu
Copy link
Member

With #193, the endpoints were made more consistent. See this comment for more details. These changes will be released in an upcoming version 2.0.

@nichtich nichtich added this to the 3.0.0 milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provide sufficient documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants