Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check availability of lxml #6

Open
fgeek opened this issue May 3, 2015 · 7 comments
Open

Check availability of lxml #6

fgeek opened this issue May 3, 2015 · 7 comments

Comments

@fgeek
Copy link
Contributor

fgeek commented May 3, 2015

Currently if mechanize is missing xsssniper will say:

[X] Please install mechanize module:
    http://wwwsearch.sourceforge.net/mechanize/

But if lxml is missing it will say:

Traceback (most recent call last):
  File "xsssniper.py", line 6, in <module>
    from core.engine import Engine
  File "/home/hsalo/xsssniper/core/engine.py", line 24, in <module>
    from core.domscanner import DOMScanner
  File "/home/hsalo/xsssniper/core/domscanner.py", line 11, in <module>
    from lxml import etree
ImportError: No module named lxml

Maybe xsssniper should also give pip install -commands rather than per project URLs, but that is design decision. Also the import errors are checked several times. Is there a reason for that?

@gbrindisi
Copy link
Owner

I think it's just been a bad design decision.
Nowadays I'd like more to put a requirements.txt and have the user go trough it to met the dependencies.

@fgeek
Copy link
Contributor Author

fgeek commented Jun 4, 2015

Yes. Using requirements.txt is a good option and if "Please install x module" is used then there should be same mechanism for all components. General stacktrace when module is missing is pretty obvious too.. I can create a pull request for requirements.txt change.

@tholu
Copy link

tholu commented Apr 17, 2018

Using requirements.txt is a good way for this I would say.

@gbrindisi Are you still actively maintaining this project?

@gbrindisi
Copy link
Owner

I am not actively developing, but I can review and merge pull requests 👍

@tholu
Copy link

tholu commented Apr 17, 2018

@gbrindisi Thanks for your quick answer, packaging/releasing/publishing it for pip (#2) would be the next best thing to increase usage and pull requests.

@gbrindisi
Copy link
Owner

@tholu I will put this in my backlog

@mtechmycourse
Copy link

Yes, I successfully get the output of the project Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants