Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Merging project to use TypeScript #184

Open
gbowne1 opened this issue Apr 24, 2023 · 4 comments
Open

[feature]: Merging project to use TypeScript #184

gbowne1 opened this issue Apr 24, 2023 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Apr 24, 2023

Is your feature request related to a problem? Please describe.

A couple of recommendations came through in the psst 4 months to merge this into using TypeScript.

Personally I feel

Describe the solution you would like

We can decide as a community if we need all of the features TypeScript offers to change to TypeScript.

Describe the alternatives you have tried

We are currently using JSX for our components with some .js for our controllers and also prop types. This has been working fihe.

Additional context

We can discuss this new feat here.

@gbowne1 gbowne1 added enhancement New feature or request question Further information is requested labels Apr 24, 2023
@pawel975
Copy link
Collaborator

pawel975 commented Apr 29, 2023

Using TypeScript would allow to create interfaces, it's kind of pattern to predefine object properties types. It would throw error if it doesn't fit during development. While components props can be handled by PropTypes, we can use interface multiple times within component (not sure if PropTypes can do that too).

image

That's example from TypeScript docs. All .js and .jsx files could be transformed into .ts and .tsx without any error because TypeScript is a superset of JavaScript and all JS code run perfectly in .ts files.

@gbowne1
Copy link
Owner Author

gbowne1 commented Apr 29, 2023

It will be something to do in the future once we get enough working. I can do prop types. I really need to sit and learn Typescript.

@pawel975
Copy link
Collaborator

Sure, if you change your mind I can handle this migration.

@gbowne1
Copy link
Owner Author

gbowne1 commented Apr 30, 2023

Great, good to know. I think its a great idea. Several have mentioned it I think we should to this when the majority of our features are complete and we still have a long way to go. I wanna get dashboards, messaging/chat, groups and friends up and working at least somewhat. We are almost done with Events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: No status
Development

No branches or pull requests

2 participants