Skip to content

Commit

Permalink
Update added-mass of lrauv model and remove added mass definitions from
Browse files Browse the repository at this point in the history
examples

Fixes #2575

Since, we have decided to deprecate added mass in the hydrodynamics
plugin in favour of Rigid Bodies, we should update our
examples to avoid the warning.

TODO: Update maritime tutorials and migration guide.

Signed-off-by: Arjo Chakravarty <[email protected]>
  • Loading branch information
arjo129 committed Sep 9, 2024
1 parent 96775c8 commit daaf518
Show file tree
Hide file tree
Showing 8 changed files with 13 additions and 70 deletions.
24 changes: 3 additions & 21 deletions examples/worlds/acoustic_comms_demo.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@

<include>
<pose>0 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<!-- Acoustic comms endpoint -->
<plugin
Expand Down Expand Up @@ -148,12 +148,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<xUU>-6.2282</xUU>
<xU>0</xU>
<yVV>-601.27</yVV>
Expand All @@ -172,7 +166,7 @@

<include>
<pose>15 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>
<name>triton</name>

<!-- Acoustic comms endpoint -->
Expand Down Expand Up @@ -250,12 +244,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<xUU>-6.2282</xUU>
<xU>0</xU>
<yVV>-601.27</yVV>
Expand All @@ -274,7 +262,7 @@

<include>
<pose>-15 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>
<name>daphne</name>

<!-- Acoustic comms endpoint -->
Expand Down Expand Up @@ -352,12 +340,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<xUU>-6.2282</xUU>
<xU>0</xU>
<yVV>-601.27</yVV>
Expand Down
8 changes: 1 addition & 7 deletions examples/worlds/auv_controls.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@

<include>
<pose>0 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI%20Tethys%20LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<!-- Joint controllers -->
<plugin
Expand Down Expand Up @@ -141,12 +141,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<xUabsU>-6.2282</xUabsU>
<xU>0</xU>
<yVabsV>-601.27</yVabsV>
Expand Down
12 changes: 2 additions & 10 deletions examples/worlds/dvl_world.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,11 @@
</visual>
</link>
</model>

<include>
<pose>0 0 -80 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<experimental:params>
<experimental:params>U
<sensor
element_id="base_link" action="add"
name="teledyne_pathfinder_dvl"
Expand Down Expand Up @@ -267,13 +266,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<xUabsU>-6.2282</xUabsU>
<xU>0</xU>
<yVabsV>-601.27</yVabsV>
<yV>0</yV>
Expand Down
8 changes: 1 addition & 7 deletions examples/worlds/lrauv_control_demo.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@

<include>
<pose>0 0 1 0 0 0</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<plugin
filename="gz-sim-odometry-publisher-system"
Expand Down Expand Up @@ -250,12 +250,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<xUabsU>-6.2282</xUabsU>
<xU>0</xU>
<yVabsV>-601.27</yVabsV>
Expand Down
25 changes: 3 additions & 22 deletions examples/worlds/multi_lrauv_race.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@

<include>
<pose>0 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<!-- Joint controllers -->
<plugin
Expand Down Expand Up @@ -128,12 +128,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<yUabsU>-6.2282</yUabsU>
<xU>0</xU>
<yVabsV>-601.27</yVabsV>
Expand All @@ -152,7 +146,7 @@

<include>
<pose>5 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>
<name>triton</name>

<!-- Joint controllers -->
Expand Down Expand Up @@ -222,13 +216,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<yUabsU>-6.2282</yUabsU>
<xU>0</xU>
<yVabsV>-601.27</yVabsV>
<yV>0</yV>
Expand All @@ -246,7 +233,7 @@

<include>
<pose>-5 0 1 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>
<name>daphne</name>

<!-- Joint controllers -->
Expand Down Expand Up @@ -316,12 +303,6 @@
filename="gz-sim-hydrodynamics-system"
name="gz::sim::systems::Hydrodynamics">
<link_name>base_link</link_name>
<xDotU>-4.876161</xDotU>
<yDotV>-126.324739</yDotV>
<zDotW>-126.324739</zDotW>
<kDotP>0</kDotP>
<mDotQ>-33.46</mDotQ>
<nDotR>-33.46</nDotR>
<yUabsU>-6.2282</yUabsU>
<xU>0</xU>
<yVabsV>-601.27</yVabsV>
Expand Down
2 changes: 1 addition & 1 deletion test/worlds/bottomless_pit.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@

<include>
<pose>0 0 -80 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<experimental:params>
<sensor
Expand Down
2 changes: 1 addition & 1 deletion test/worlds/flat_seabed.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@

<include>
<pose>0 0 -80 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<experimental:params>
<sensor
Expand Down
2 changes: 1 addition & 1 deletion test/worlds/underwater_currents.sdf
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@

<include>
<pose>0 0 -0.5 0 0 1.57</pose>
<uri>https://fuel.gazebosim.org/1.0/accurrent/models/MBARI Tethys LRAUV</uri>
<uri>https://fuel.gazebosim.org/1.0/arjo129/models/LRAUV-PostIonic</uri>

<experimental:params>
<sensor
Expand Down

0 comments on commit daaf518

Please sign in to comment.