Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on bias factor #415

Open
frede791 opened this issue Feb 22, 2024 · 4 comments
Open

Turn on bias factor #415

frede791 opened this issue Feb 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@frede791
Copy link

Desired behavior

The IMU plugin in old gazebo used a factor called turn_on_bias_sigma factor for modelling noise.
https://github.com/PX4/PX4-SITL_gazebo-classic/blob/33ac87a37676fb597de110e926bbf0a080169ffe/src/gazebo_imu_plugin.cpp#L173C3-L180C4
As far as I can tell there is currently no way to model this in any way? Would it be possible to add this as a specifiable tag that can be used in the noise model?

Implementation suggestion

Add an additional tag that can be read out in GaussianNoiseModel.cc and added as a factor in the Load() function

@frede791 frede791 added the enhancement New feature or request label Feb 22, 2024
@azeey
Copy link
Contributor

azeey commented Mar 12, 2024

Is this different from the bias_mean and bias_stddev parameters?

@frede791
Copy link
Author

Yes, as far as I understand, the noise model that is employed is slightly different to the old one that was used previously.

@azeey
Copy link
Contributor

azeey commented Mar 14, 2024

Could you elaborate more? Based on the lines of code you linked to, it seems to me that we can set bias_mean=0 and bias_stddev=<turn_on_bias_sigma> to get the same results. cc @mjcarroll

@mjcarroll
Copy link
Contributor

Based on the lines of code you linked to, it seems to me that we can set bias_mean=0 and bias_stddev=1.0 to get the same results

Yes, this should accomplish the same results. With the IMU, we model both a static (turn-on) bias as well as a dynamic (time varying) bias.

The turn on bias is drawn from a gaussian distribution modelled with mean bias_mean and stddev bias_stddev when the sensor is loaded.

@azeey azeey moved this from Inbox to In progress in Core development Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

No branches or pull requests

3 participants