From fac43a8aa09e152aa65b917fe78488a350d1fe4d Mon Sep 17 00:00:00 2001 From: Silvio Traversaro Date: Tue, 3 Oct 2023 21:43:55 +0200 Subject: [PATCH 1/3] Set GZ_TOOLS_VER to 2 for consistency with rest of Garden and Harmonic libraries (#391) Signed-off-by: Silvio Traversaro --- CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2a9e8ed0..7a4a6699 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -97,7 +97,7 @@ set(GZ_MATH_VER ${gz-math7_VERSION_MAJOR}) # Note that CLI files are installed regardless of whether the dependency is # available during build time find_program(HAVE_GZ_TOOLS gz) -set(GZ_TOOLS_VER 1) +set(GZ_TOOLS_VER 2) #-------------------------------------- # Find Tinyxml2 From 1b0b0f8c978487799f92fe8ad37156d5a97e1953 Mon Sep 17 00:00:00 2001 From: Arjo Chakravarty Date: Fri, 27 Oct 2023 19:58:58 -0700 Subject: [PATCH 2/3] Fix compiler warning in `generator.cc` (#403) Signed-off-by: Arjo Chakravarty --- src/Generator.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Generator.cc b/src/Generator.cc index ffac7bff..afa3b0a8 100644 --- a/src/Generator.cc +++ b/src/Generator.cc @@ -149,7 +149,7 @@ bool Generator::Generate(const FileDescriptor *_file, auto ns = getNamespaces(_file->package()); - for (const auto name : ns) + for (const auto &name : ns) printer.PrintRaw("namespace " + name + " {\n"); for (auto i = 0; i < _file->message_type_count(); ++i) From 29cfe33bc5dd51a2f9ed263208880d06334c732e Mon Sep 17 00:00:00 2001 From: Michael Carroll Date: Mon, 11 Dec 2023 12:39:08 -0600 Subject: [PATCH 3/3] Bazel: Fix py_binary location (#406) Signed-off-by: Michael Carroll --- BUILD.bazel | 2 +- tools/BUILD.bazel | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/BUILD.bazel b/BUILD.bazel index 9e8e3c84..9a23f639 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -129,7 +129,7 @@ test_sources = glob( "test/desc", ], defines = [ - 'GZ_MSGS_TEST_PATH=\\"msgs/test\\"', + 'GZ_MSGS_TEST_PATH=\\"msgs/test\\"', ], deps = [ ":msgs", diff --git a/tools/BUILD.bazel b/tools/BUILD.bazel index 8bdd14a8..bba0c8c1 100644 --- a/tools/BUILD.bazel +++ b/tools/BUILD.bazel @@ -1,7 +1,8 @@ -load("@gz//bazel/skylark:gz_py.bzl", "gz_py_binary") +load("@gz//bazel/skylark:build_defs.bzl", "gz_py_binary") gz_py_binary( name = "gz_msgs_generate_py", srcs = ["gz_msgs_generate.py"], + main = "gz_msgs_generate.py", visibility = ["//visibility:public"], )