Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose message generation framework #36

Closed
osrf-migration opened this issue Feb 24, 2020 · 2 comments
Closed

Expose message generation framework #36

osrf-migration opened this issue Feb 24, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@osrf-migration
Copy link

Original report (archived issue) by Anonymous.


Summary

I'm trying to add custom messages to my ignition project. Since ign-msgs doesn't seem to expose this functionality, I had to copy the cmake macro ign_msgs_protoc from ign-msgs/src/CMakeLists.txt into my own project, along with the generator source files: ign-msgs/src/Generator.cc, ign-msgs/src/Generator.hh, ign-msgs/src/generator_main.cc. Although this works, it's not a clean solution. Are there any plans to export the message generation framework so it can be used by other projects?

@osrf-migration
Copy link
Author

Original comment by Louise Poubel (Bitbucket: chapulina, GitHub: chapulina).


Could you elaborate on your use case? Ignition Transport is able to publish any Protobuf messages, not only Ignition Messages. See the example here where a custom string message is created and published with publisher_custom_msg. Does that cover your use case?

Are there any plans to export the message generation framework so it can be used by other projects?

I don't think there is. But if there's a valid use case we could consider.

@mjcarroll
Copy link
Contributor

This was completed in #339, tutorial added in: #386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants