Use STL functions in parseInt and parseFloat

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

Helpers.hh has functions parseInt and parseFloat that are similar to std::stoi and std::stof. These should use the STL functions where possible.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

In 3c6f86f, I've modified the existing parse* functions to use the standard library and attempt to match the current behavior for edge cases. There are currently two failed test expectations:

[ RUN      ] HelpersTest.Helpers
src/Helpers_TEST.cc:37: Failure
Value of: math::parseInt("23ab67")
  Actual: 23
Expected: math::NAN_I
Which is: 0
src/Helpers_TEST.cc:54: Failure
Value of: math::isnan(math::parseFloat("23ab67"))
  Actual: false
Expected: true
[  FAILED  ] HelpersTest.Helpers (1 ms)

https://drone.io/bitbucket.org/ignitionrobotics/ign-math/704

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• Edited issue description* changed title from "Deprecate parseInt and parseFloat in favor of standard library" to "Use STL functions in parseInt and parseFloat"

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

pull request #224

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

• changed state from "new" to "resolved"

pull request #224