Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpers_TEST fails on arm64 debbuilds #485

Open
scpeters opened this issue Aug 15, 2022 · 2 comments
Open

Helpers_TEST fails on arm64 debbuilds #485

scpeters opened this issue Aug 15, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@scpeters
Copy link
Member

Environment

  • OS Version: Ubuntu 18.04, 20.04, 22.04, debian Buster
  • Source or binary build? debbuild for arm64 architecture

Description

  • Expected behavior: test passes (as it does on other architectures)
  • Actual behavior: test fails
[ RUN      ] HelpersTest.AppendToStream
/home/jenkins/workspace/ign-math6-debbuilder/build/ignition-math-6.12.0/src/Helpers_TEST.cc:1012: Failure
Expected equality of these values:
  out.str()
    Which is: "0 456 0 3.14159 3.141592654 3.141592653589793238462643383279503"
  "0 456 0 3.14159 3.141592654 3.141592653589793239"
/home/jenkins/workspace/ign-math6-debbuilder/build/ignition-math-6.12.0/src/Helpers_TEST.cc:1022: Failure
Expected equality of these values:
  out.str()
    Which is: "0 456 0 3.14159 3.141592654 3.141592653589793238462643383279503 3.14"
  "0 456 0 3.14159 3.141592654 3.141592653589793239 3.14"
[  FAILED  ] HelpersTest.AppendToStream (0 ms)

Steps to reproduce

  1. Rebuild the following jobs

Output

@scpeters scpeters added the bug Something isn't working label Aug 15, 2022
@j-rivero
Copy link
Contributor

This one is new to me. Somehow arm64 is rounding up the precision for PI while the other arches are not doing it. Not sure the severity of the issue since it is affecting what seems to an str method. If the problem of the lost of precision is affecting only string representation we could potentially ignore the error if the tests if we consider it superficial, if the problem is deep in the number real value then should be fixed.

@j-rivero
Copy link
Contributor

Going to leave the issue open, see #510 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

2 participants