Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gz fuel server allows models with duplicate author and name #420

Open
luca-della-vedova opened this issue Apr 30, 2024 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@luca-della-vedova
Copy link
Member

It seems two models with exactly the same name and author made it into the gazebo app portal:

image

Clicking each of them points to the same page https://app.gazebosim.org/anni/models/ur5_rg2.

This is causing a fair bit of issue in the Open-RMF side of things where we use model names to build a cache of fuel models and I believe it is probably not indended behavior?

@luca-della-vedova luca-della-vedova added the bug Something isn't working label Apr 30, 2024
@azeey
Copy link
Contributor

azeey commented Apr 30, 2024

@luca-della-vedova can you verify if this is still a problem. There was a caching issue on the Fuel server that was resolved last week which might have also fixed this. The URL for the ur5 model in the description no longer works for example.

@azeey
Copy link
Contributor

azeey commented Apr 30, 2024

However, I do see that the model count is 2 when searching for ur5 even though there's only one model shown
image

@luca-della-vedova
Copy link
Member Author

luca-della-vedova commented May 2, 2024

The way I'm using to verify the issue is to look at the models page, since the model has been uploaded fairly recently it appears in the page as one of the latest ones:

image

Edit: Since the endpoint we are using in RMF is the one to list all the models I wonder if the behavior of this page is different from the searching that you tried?

@azeey
Copy link
Contributor

azeey commented May 2, 2024

It looks like listing the model of just that owner shows there's one model, but if I list all models, it shows two ur5_rg2 models owned by anni.

$ gz fuel list -v4 -t model -o anni
Fetching model list from https://fuel.gazebosim.org...
Received model list (took 5ms).
https://fuel.gazebosim.org
└── anni
    └── ur5_rg2
1 owners, 1 models

$ gz fuel list -v4 -t model 
Fetching model list from https://fuel.gazebosim.org...
Received model list (took 57653ms).
https://fuel.gazebosim.org
...
├── anni
│   ├── ur5_rg2
│   └── ur5_rg2

cc @nkoenig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

3 participants