Specify required components in pkg-config #451
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #450.
Summary
When a
gz-*
package is found withfind_package
, its cmake config file encodes the list of required dependencies in its pkg-config file. If the package is found with required components, those components should be encoded in the pkg-config file as well. This uses the existing for loop over components in thegz-config.cmake.in
file and stores the names of required components, then appends them to the string passed togz_pkg_config_entry
.I spent some time trying to add a test for this in branch
scpeters/test_component_export
( gz-cmake4...scpeters/test_component_export ) but have not yet been successful. I've tested this fix manually and think it works.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.