Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gz-cmake support colcon's symlink-install #288

Open
mjcarroll opened this issue Jul 29, 2022 · 0 comments
Open

Make gz-cmake support colcon's symlink-install #288

mjcarroll opened this issue Jul 29, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mjcarroll
Copy link
Contributor

Desired behavior

Make packages built by developers with colcon respect the symlink-install argument from the command line.

This is very convenient for developers who are rapidly iterating on files that shouldn't require a "make install" every time.

Implementation suggestion

colcon_ros accomplishes this by setting an additional flag AMENT_CMAKE_SYMLINK_INSTALL=1 to be passed to the cmake invocation: https://github.com/colcon/colcon-ros/blob/d7a66047e5aac95ee31eee2ef837f76919e2be9e/colcon_ros/task/ament_cmake/build.py#L50-L53

Given this flag, ament_cmake then overrides the default cmake install() behavior such that symlinks are used, rather than actually copying the files: https://github.com/ament/ament_cmake/tree/966930aca4f8a0b57245a8da9e7be45861de17fc/ament_cmake_core/cmake/symlink_install

@mjcarroll mjcarroll added the enhancement New feature or request label Jul 29, 2022
@mjcarroll mjcarroll added the help wanted Extra attention is needed label Jul 30, 2022
@azeey azeey moved this to To do in Core development Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

1 participant