Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindIgnOGRE2: how to find a from-source (non-system) install? #192

Closed
peci1 opened this issue Nov 8, 2021 · 7 comments
Closed

FindIgnOGRE2: how to find a from-source (non-system) install? #192

peci1 opened this issue Nov 8, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@peci1
Copy link
Contributor

peci1 commented Nov 8, 2021

Environment

  • OS Version: Ubuntu 18.04
  • Source or binary build? Source 3971db8

Description

  • Expected behavior: FindIgnOGRE2 finds local source build of OGRE2 if it is in CMAKE_PREFIX_PATH
  • Actual behavior: It finds the system-installed one.

I have OGRE2 source build in a colcon workspace together with ign-rendering4. I don't see a way to point FindIgnOGRE2 to this source build. In the CMake module, first a check for OGRE-2.1 is done, and if found, the rest of the search logic is skipped. And as the comment correctly points out, OGRE-2.1 is the name of the system-installed binary library, whereas source libraries use just OGRE. So once there is an OGRE-2.1 installed in the system, the CMake module doesn't allow me to point it anywhere else...

@peci1 peci1 added the bug Something isn't working label Nov 8, 2021
@mjcarroll
Copy link
Contributor

There isn't a consistent way to do it at the moment. We do all of the name mangling via the Debian packaging step, so it's not reflected in the CMake.

In the past, @ahcorde and I hardcoded paths to be able to use the colcon-local version, but I don't know if that is current best practice.

@traversaro
Copy link
Contributor

Just to crossref the related issues, eventually this problem will be solved upstream by OGRECave/ogre-next#232 .

@peci1
Copy link
Contributor Author

peci1 commented Nov 8, 2021

Ok, good to hear there is activity to solve it upstream ;)

@j-rivero
Copy link
Contributor

The use case of having OGRE2 compiled via colcon workspace should have been covered by #174. Not sure if it cover your specific use case but should be supported.

@azeey
Copy link
Contributor

azeey commented Oct 5, 2023

Has this been fixed by either #342 or #384?

@iche033
Copy link
Contributor

iche033 commented Oct 5, 2023

#342 makes it work with ogre 2.3 from our fork: https://github.com/gazebo-forks/ogre-next/tree/gazebo/v2-3 in a colcon workspace.

ogre-next needs to be built with these variables: https://github.com/gazebo-forks/ogre-next/blob/gazebo/v2-3/colcon.pkg

@azeey
Copy link
Contributor

azeey commented Nov 30, 2023

Closing since it's fixed by #342.

@azeey azeey closed this as completed Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants