ffmpeg 3.1 deprecation warnings on homebrew

[osrf-migration]

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

ffmpeg 3.1 is now the default version in homebrew, and it has deprecated some things that are used in gazebo.

• http://build.osrfoundation.org/job/gazebo-ci-default-homebrew-amd64/103/warnings8Result/

/usr/local/Cellar/ffmpeg/3.1/include/libavformat/avformat.h:880:21: note: 'codec' has been explicitly marked deprecated here
    AVCodecContext *codec;
                    ^

/usr/local/Cellar/ffmpeg/3.1/include/libavcodec/avcodec.h:4753:5: note: 'avcodec_decode_video2' has been explicitly marked deprecated here
int avcodec_decode_video2(AVCodecContext *avctx, AVFrame *picture,
    ^


/usr/local/Cellar/ffmpeg/3.1/include/libavcodec/avcodec.h:4704:5: note: 'avcodec_decode_audio4' has been explicitly marked deprecated here
int avcodec_decode_audio4(AVCodecContext *avctx, AVFrame *frame,
    ^

We can try to depend on something old like homebrew/versions/ffmpeg28, or we can upgrade to the new interfaces if they exist in the versions of libavcodec and libavformat used on trusty.

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

ffmpeg recommends using avcodec_send_packet() and avcodec_receive_frame() instead of the deprecated functions. I don't see these on trusty.

We can also use ifdef's to support old and new versions.

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

I'll start work on this today. It dovetails nicely into other work.

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set assignee_account_id to "557058:095b1e12-74ed-4e20-b44f-2f0745b616e0"
• set assignee to "nkoenig (Bitbucket: nkoenig, GitHub: nkoenig)"

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

I've added code to ignore these warnings for now in e3322aa (branch issue_2002_ignore) and started a jenkins test build to confirm the fix

• http://build.osrfoundation.org/job/gazebo-ci-pr_any-homebrew-amd64/561/

I'll make a pull request for this to clean up our CI if a more complete is not imminent

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

warnings are fixed

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

warnings disabled in pull request #2388

[osrf-migration]

Original comment by Ian Chen (Bitbucket: Ian Chen, GitHub: iche033).

---

can probably do something similar to pull request #2154

ffmpeg 3.1 uses libavcodec version 57.48.101

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

@iche033 that's a good idea; I just don't know what the new API's should be

and I think @nkoenig is actively working on this for video recording

[osrf-migration]

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).

---

warnings are currently disabled, but we should use the new API's with ifdef's

[osrf-migration]

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).

---

• set version to "all"

[traversaro]

Fixed by #3195 .