Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: GitHub action to check for ignition #727

Open
methylDragon opened this issue May 16, 2022 · 1 comment
Open

Feature Request: GitHub action to check for ignition #727

methylDragon opened this issue May 16, 2022 · 1 comment

Comments

@methylDragon
Copy link
Contributor

With the ignition -> gz migration (with tick-tocks), certain manual development steps need to be done (e.g. manually creating redirection headers). The need for these manual steps creates a high probability of creating unintentional regressions if a forward port or other pull request introduces new ignition headers, namespaces, or source names.

It would be good to create a GitHub action to check for this and introduce a warning to ensure that any new files adhere to the structures introduced with the migration (e.g. ignition headers should only have a license and includes to the gz headers.)

This issue will be used to track what it means to adhere to the migration structure.


  • Newly added headers should be gz
    • Corresponding ignition redirection headers should be created that point to them
    • detail headers may be skipped
  • New components need to have manually created ignition/<lib>/<component>/Export.hh header files created for the component
@scpeters
Copy link
Contributor

part of #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants