You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the ignition -> gz migration (with tick-tocks), certain manual development steps need to be done (e.g. manually creating redirection headers). The need for these manual steps creates a high probability of creating unintentional regressions if a forward port or other pull request introduces new ignition headers, namespaces, or source names.
It would be good to create a GitHub action to check for this and introduce a warning to ensure that any new files adhere to the structures introduced with the migration (e.g. ignition headers should only have a license and includes to the gz headers.)
This issue will be used to track what it means to adhere to the migration structure.
Newly added headers should be gz
Corresponding ignition redirection headers should be created that point to them
detail headers may be skipped
New components need to have manually created ignition/<lib>/<component>/Export.hh header files created for the component
The text was updated successfully, but these errors were encountered:
With the ignition -> gz migration (with tick-tocks), certain manual development steps need to be done (e.g. manually creating redirection headers). The need for these manual steps creates a high probability of creating unintentional regressions if a forward port or other pull request introduces new
ignition
headers, namespaces, or source names.It would be good to create a GitHub action to check for this and introduce a warning to ensure that any new files adhere to the structures introduced with the migration (e.g. ignition headers should only have a license and includes to the gz headers.)
This issue will be used to track what it means to adhere to the migration structure.
gz
ignition
redirection headers should be created that point to themdetail
headers may be skippedignition/<lib>/<component>/Export.hh
header files created for the componentThe text was updated successfully, but these errors were encountered: