Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Constraints API v0 #49

Merged
merged 34 commits into from
Nov 29, 2024
Merged

feat: Constraints API v0 #49

merged 34 commits into from
Nov 29, 2024

Conversation

thedevbirb
Copy link
Contributor

This PR introduces the Constraints API in Helix.

merklefruit
merklefruit suggested changes Nov 7, 2024
View reviewed changes
Copy link

@merklefruit merklefruit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tagging some broken docs links

crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
crates/api/src/proposer/api.rs Outdated Show resolved Hide resolved
crates/common/src/config.rs Outdated Show resolved Hide resolved
crates/common/src/bid_submission/submission.rs Outdated Show resolved Hide resolved
thedevbirb and others added 2 commits November 7, 2024 15:53
@thedevbirb @merklefruit
@mempirate @namn-grg
feat: constraints-api-v0
22a13a8 
Co-authored-by: merklefruit <[email protected]>
Co-authored-by: mempirate <[email protected]>
Co-authored-by: namn-grg <[email protected]>
@thedevbirb
docs(constraints-api): fix broken links
f2f2fcf
thedevbirb and others added 23 commits November 8, 2024 11:04
@thedevbirb
fix(constraints-api-v0): drop validator_delegations migration, curren…
dc2919d 
…tly stored only in cache
@thedevbirb
feat(constraints-api): add startup configuration
40cda8e
@merklefruit
Merge pull request #22 from chainbound/lore/feat/constraints-api-config
38c8e8f 
feat(constraints-api): add startup configuration
@gd-0
introduce max_block_value_to_verify in constraints config
ffc5e5e
@gd-0
address PR comments + other fixes
61d611f 
- fix lints + other refactoring
- max_block_value_to_verify_wei now U256 to handle big value cases
- return earlier in get_header_with_proofs call
@merklefruit @DigiDr @austonst
feat: import website from aestus upstream, solve conflicts
b531d46 
Co-authored-by: DigiDr <[email protected]>
Co-authored-by: austonst <[email protected]>
@merklefruit
chore: re-added cargo.lock
b66e136
@merklefruit
chore: run fmt clippy checks
9d7e97f
@merklefruit
chore: default run on unspecified ip
f995522
@merklefruit
chore: rm aestus naming and links from web page
30c5cb5
@merklefruit
chore: gattaca logo
8ba703c
@merklefruit
chore: reverted changes to dockerfile + tls dependencies
25d777e
@merklefruit
chore: addressed review
c864a9e
@merklefruit
chore: logo size
9ee178a
@thedevbirb
fix(tests): make them compile
ea15474
@thedevbirb
chore(api): should verify proofs logic
ae59749
@thedevbirb
Merge pull request #23 from gd-0/dont-enforce-constraints-if-block-va…
00b5bcb 
…lue-is-above-threshold

introduce max_block_value_to_verify in constraints config
@thedevbirb
chore(website): fmt
9003727
@thedevbirb
Merge pull request #25 from chainbound/feat/import-website
0aee3e8 
feat: import website from aestus upstream, solve conflicts
@merklefruit
fix(db): retry creating pool handle
30c66ac
@merklefruit
fix(db): don't panic upon failing migrations once
7a0342f
@merklefruit
fix(website): rm blob related fields from table
44b1823
@thedevbirb
Merge pull request #26 from chainbound/fix/retry-db-pool
f778527 
fix(db): retry creating pool handle
@thedevbirb thedevbirb marked this pull request as ready for review November 14, 2024 08:24
@merklefruit
Merge pull request #27 from chainbound/lore/fix/ssz
cdb2795 
fix(ssz): backwards compatibility on `SignedBidSubmission`
gd-0
gd-0 approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@gd-0 gd-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

Just some minor comments that aren't critical to address before we merge.

Thanks for the PR!

crates/common/src/api/constraints_api.rs Outdated Show resolved Hide resolved
crates/common/src/proofs.rs Outdated Show resolved Hide resolved
crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
crates/api/src/builder/api.rs Outdated Show resolved Hide resolved
0w3n-d
0w3n-d approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@0w3n-d 0w3n-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main issue with this PR is it seems to assume everything is talking to the same redis. But maybe we can fix this in a follow up PR.

crates/api/src/constraints/api.rs Outdated Show resolved Hide resolved
@thedevbirb thedevbirb mentioned this pull request Nov 27, 2024
Merged
gd-0
gd-0 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@gd-0 gd-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@0w3n-d 0w3n-d merged commit ac3738e into gattaca-com:develop Nov 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit requested changes

@gd-0 gd-0 gd-0 approved these changes

@0w3n-d 0w3n-d 0w3n-d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thedevbirb @merklefruit @0w3n-d @gd-0