fix(gatsby): freeze the schema only after rebuilding with SitePage #30132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: GraphQL
pieh
approved these changes
Mar 9, 2021
vladar
changed the title
|
Hi , |
vladar
added a commit
that referenced
this pull request
Mar 9, 2021
…30132) (#30137) (cherry picked from commit 4fc4248) Co-authored-by: Vladimir Razuvaev <[email protected]>
|
Published in |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR #29822 introduced an issue: types derived from
SitePageare not updated correctly because theQuerytype gets frozen too early and doesn't receive needed updates when rebuilding the schema withSitePage.This PR moves type freezing to a safer stage - after the schema is updated with
SitePageand all of it's derived types.Related Issues
Fixes #30107