chore(docs): gatsby image - code block langue, fix snippets, fences a… #28934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
muescha
commented
Jan 8, 2021
LekoArts
added
type: documentation
|
Hi @muescha , |
ascorbic
reviewed
Jan 11, 2021
| // ⚠️ Doesn't work | ||
|
|
||
| ({ logo }) => <Img src={logo}> | ||
| import React from "react" | ||
| import Img from "gatsby-image" |
There was a problem hiding this comment.
This is not correct. The component is StaticImage from "gatsby-plugin-image"
|
OK, after reviewing I'm afraid I'm not going to merge it. There are a number of mistakes in the changes, as well as other outdated information in the old docs. I am going to update this with the new, correct docs soon. Thanks again for your help, but I'd hold off on working on this plugin until it's stable |
|
ok - i wait until stable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes:
jsx<Img />tags, add import forImgDocumentation
Related Issues
docs(gatsby-plugin-image): Update readme