Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gatsby-link): add example of passing state #10137

Merged
merged 11 commits into from
Nov 28, 2018
Merged

Conversation

GarrettJMU
Copy link
Contributor

Update docs to show how state is passed through the location object.

Update docs to show how state is passed through the location object.
@GarrettJMU GarrettJMU requested a review from a team November 26, 2018 15:40
Copy link
Contributor

@jgierer12 jgierer12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes for better syntax highlighting ✨

Please also make sure to format this file with Prettier.

docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
docs/docs/gatsby-link.md Outdated Show resolved Hide resolved
@GarrettJMU
Copy link
Contributor Author

@jgierer12 updated the copy. Good call, much better read now.

@jgierer12
Copy link
Contributor

Thank you! Please also download Prettier and use it to format the file, that will get rid of the failing CI too 😉

@GarrettJMU
Copy link
Contributor Author

@jgierer12 should pass now.

@pieh pieh changed the title Update Link/Navigate state docs docs(gatsby-link): add example of passing state Nov 28, 2018
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GarrettJMU and @jgierer12!

@pieh pieh merged commit 992cd53 into gatsbyjs:master Nov 28, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 28, 2018

Holy buckets, @GarrettJMU — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Update docs to show how state is passed through the location object.

<!--
  Q. Which branch should I use for my pull request?
  A. Use `master` branch (probably).

  Q. Which branch if my change is a bug fix for Gatsby v1?
  A. In this case, you should use the `v1` branch

  Q. Which branch if I'm still not sure?
  A. Use `master` branch. Ask in the PR if you're not sure and a Gatsby maintainer will be happy to help :)

  Note: We will only accept bug fixes for Gatsby v1. New features should be added to Gatsby v2.

  Learn more about contributing: https://www.gatsbyjs.org/docs/how-to-contribute/
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants