-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility docs page #10006
Accessibility docs page #10006
Conversation
The article is very good, what do you plan to add? Is there any issue that you can help? |
Thanks ! 😄 I didn't really plan to add any more content as I haven't ever used Gatsby (only the tutorial) and I feel like I would need to know some framework related things in order to do so. On the original issue it stated that the page would be expanded in the future, that's why I created the last section. We could also for sure add some common best practices, but I still don't know which ones are frequent in Gatsby projects. |
@enzoferey hey! i made a couple tweaks.
|
Looks way better indeed ! 😄 What about Prettier failing tests, should I fix them ? |
@enzoferey definitely! You should be able to fix with Otherwise, you can run |
Done ! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for getting this doc started, @enzoferey! 🙏🏼
Holy buckets, @enzoferey — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
* Created the page. * Page content. * Link in the blog post. * Source attribution, language tweaks * Fixed Prettier error.
Following up #5592, I created the docs page and added the cross link in the blog post.
Open for feedback ! 😄