Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility docs page #10006

Merged
merged 5 commits into from
Nov 29, 2018
Merged

Accessibility docs page #10006

merged 5 commits into from
Nov 29, 2018

Conversation

enzoferey
Copy link
Contributor

Following up #5592, I created the docs page and added the cross link in the blog post.

Open for feedback ! 😄

@enzoferey enzoferey requested a review from a team November 17, 2018 21:25
@enzoferey enzoferey requested a review from a team as a code owner November 17, 2018 21:25
@devrchancay
Copy link
Contributor

The article is very good, what do you plan to add? Is there any issue that you can help?

@enzoferey
Copy link
Contributor Author

Thanks ! 😄

I didn't really plan to add any more content as I haven't ever used Gatsby (only the tutorial) and I feel like I would need to know some framework related things in order to do so. On the original issue it stated that the page would be expanded in the future, that's why I created the last section.

We could also for sure add some common best practices, but I still don't know which ones are frequent in Gatsby projects.

@amberleyromo
Copy link
Contributor

@enzoferey hey! i made a couple tweaks.

  1. added some attribution for some of the quoted claims on the page.
  2. linked out to some learning resources
  3. clarified that accessibility is an active process that can't be solved out of the box, but highlighting ways we try to support.

@enzoferey
Copy link
Contributor Author

enzoferey commented Nov 29, 2018

Looks way better indeed ! 😄 What about Prettier failing tests, should I fix them ?

@DSchau
Copy link
Contributor

DSchau commented Nov 29, 2018

@enzoferey definitely!

You should be able to fix with npx prettier --write docs/docs/making-your-site-accessible.md presuming you're on at least npm 5.

Otherwise, you can run npm install -g prettier and then prettier --write docs/docs/making-your-site-accessible.md

@enzoferey
Copy link
Contributor Author

Done ! 👍

Copy link
Contributor

@amberleyromo amberleyromo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for getting this doc started, @enzoferey! 🙏🏼

@amberleyromo amberleyromo merged commit 228a866 into gatsbyjs:master Nov 29, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 29, 2018

Holy buckets, @enzoferey — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@enzoferey enzoferey deleted the accessibility-docs-page branch November 29, 2018 16:30
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
* Created the page.

* Page content.

* Link in the blog post.

* Source attribution, language tweaks

* Fixed Prettier error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants