fix(gatsby): Set trailingSlash default to "always" #36798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
pieh
reviewed
Oct 20, 2022
| @@ -20,7 +27,7 @@ function absolutify(path, current) { | |||
| const absolutePath = resolve(path, current) | |||
|
|
|||
| if (option === `always` || option === `never`) { | |||
| return applyTrailingSlashOption(absolutePath, option) | |||
| return applyTrailingSlashOptionOnPathnameOnly(absolutePath, option) | |||
There was a problem hiding this comment.
Is this basically what #36828 is doing?
pieh
approved these changes
Oct 20, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cont'd from #34268 setting our default value for
trailingSlashfromlegacytoalways+ removinglegacy.Documentation
Will be updated in #36763
Related Issues
[ch53712]