Upgrade to Gatsby 4 breaks Storybook #36210
Comments
sqpollen
added
the
type: bug
gatsbot
bot
added
the
status: triage needed
LekoArts
removed
the
status: triage needed
|
Please open an issue with Storybook about this. Thanks! |
|
@LekoArts Can you please re-open this? This import: Is visible in the shipped source here: https://unpkg.com/[email protected]/dist/index.modern.mjs The relevant Webpack error message is: Indeed, you can't import from |
|
For anyone who needs a workaround, add this to your root "resolutions": {
+ "gatsby-link": "4.18.1",
"lint-staged/supports-color": "8.1.1", |
|
It's a matter of correctly defining your webpack configuration to handle this and not immediately break on it, Gatsby's webpack config handles that gracefully. The But I'll release a new version of |
Sorry @LekoArts, I don't know what I looked at when I wrote this; I checked the types (which still come from
I agree it's possible, but IMO it's better to ship compliant ES modules that don't require custom end-user configs. FWIW, would an alternative fix have been to simply update the import statement to Regardless we'll appreciate this fix once it ships, thank you. |
|
You can try |
|
Thanks @LekoArts and @aaronadamsCA - got it working using Do you know when you'll officially release |
|
We release a minor every 2 weeks, so in 7 days |
|
Hey, @LekoArts is a release happening today? |
Preliminary Checks
Description
I've upgraded to Gatsby 4.0.0 using this guide and updated all gatsby-plugins. Builds are working as expected, but Storybook will not run and returns the following errors.
I've upgraded Storybook to latest version as part of troubleshooting and the error still occurs.
Here is
package.jsonReproduction Link
https://gatsby.dev/reproduction
Steps to Reproduce
Install from above package.json
Expected Result
Storybook compiles
Actual Result
Storybook produces above error
Environment
System: OS: macOS 12.4 CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz Shell: 5.8.1 - /bin/zsh Binaries: Node: 16.3.0 - ~/.nvm/versions/node/v16.3.0/bin/node Yarn: 1.22.17 - ~/.nvm/versions/node/v14.18.3/bin/yarn npm: 7.15.1 - ~/.nvm/versions/node/v16.3.0/bin/npm Browsers: Chrome: 103.0.5060.134 Firefox: 101.0.1 Safari: 15.5 npmPackages: gatsby: ^4.0.0 => 4.0.0 gatsby-plugin-algolia: ^0.26.0 => 0.26.0 gatsby-plugin-bugherd: ^1.0.2 => 1.0.2 gatsby-plugin-canonical-urls: ^4.19.0 => 4.19.0 gatsby-plugin-google-gtag: ^4.19.0 => 4.19.0 gatsby-plugin-google-tagmanager: ^4.19.0 => 4.19.0 gatsby-plugin-image: ^2.19.0 => 2.19.0 gatsby-plugin-manifest: ^4.19.0 => 4.19.0 gatsby-plugin-postcss: ^5.19.0 => 5.19.0 gatsby-plugin-react-helmet: ^5.19.0 => 5.19.0 gatsby-plugin-robots-txt: ^1.7.1 => 1.7.1 gatsby-plugin-rollbar: ^1.1.0 => 1.1.0 gatsby-plugin-rollbar-deploy: ^1.0.0 => 1.0.0 gatsby-plugin-s3: ^0.3.8 => 0.3.8 gatsby-plugin-sass: ^5.19.0 => 5.19.0 gatsby-plugin-sharp: ^4.19.0 => 4.19.0 gatsby-plugin-svgr: ^3.0.0-beta.0 => 3.0.0-beta.0 gatsby-remark-images-contentful: ^5.1.0 => 5.4.0 gatsby-source-contentful: ^6.1.4 => 6.1.4 gatsby-source-filesystem: ^3.14.0 => 3.14.0 gatsby-source-sanity: ^7.0.7 => 7.3.2 gatsby-transformer-sharp: ^3.14.0 => 3.14.0 gatsby-transformer-sqip: ^4.1.4 => 4.12.1Config Flags
The text was updated successfully, but these errors were encountered: