yet-another-abortcontroller-polyfill throwing TypeError: Illegal constructor

[aaronadamsCA]

Preliminary Checks

• This issue is not a duplicate. Before opening a new issue, please search existing issues: https://github.com/gatsbyjs/gatsby/issues
• This issue is not a question, feature request, RFC, or anything other than a bug report directly related to Gatsby. Please post those things in GitHub Discussions: https://github.com/gatsbyjs/gatsby/discussions

Description

Our error logs are filling up with "TypeError: Illegal constructor". The problem started when we upgraded from Gatsby v4.2.0 to v4.4.0.

We managed to trace the message's origin to this line of code:

https://github.com/benlesh/abort-controller-polyfill/blob/b40db6f1274a24bc7bc404339efe64a5012b3e78/index.js#L12

Which recently became part of Gatsby in #33530 here:

gatsby/packages/gatsby-legacy-polyfills/src/polyfills.js

Line 9 in c7efdb9

import "yet-another-abortcontroller-polyfill"

In addition to legacy browsers, we're seeing this error reported by Safari 13-14, Chrome 83-86, and Firefox 83, none of which I would expect to run the polyfill at all.

I downloaded Firefox 57 to reproduce the error. What I learned:

• Simply calling new AbortController() is enough to cause the error to be thrown.
• The problem crashes our site, due to other libraries (e.g. Apollo Client) using the faulty polyfill when it becomes available.

I would suggest removing the polyfill and simply not aborting requests in older browsers.

Reproduction Link

https://www.gatsbyjs.com/ using Firefox 56

Steps to Reproduce

Open the site

Expected Result

Site loads normally

Actual Result

Site throws TypeError: Illegal constructor.

• On its own this error isn't enough to crash a website, but when other libraries depend on AbortController as well, they can crash. Apollo Client is an example.
• Since the polyfill is broken, the abort functionality isn't working anyway.

Environment

Gatsby 4.4.0.

Config Flags

No response

[aaronadamsCA]

FYI @wardpeet - the AbortController polyfill introduced in #33530 is throwing an exception whenever it's used. Didn't want to @ you right before Christmas, but now that we're on the other side I'm letting you know!

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[aaronadamsCA]

I am reasonably confident this has resolved itself, @wardpeet, possibly from #33731.