fix(gatsby): add componentChunkName to components list so don't need to loop over pages #31547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to loop over pages
gatsbot
bot
added
the
status: triage needed
KyleAMathews
added
type: bug
wardpeet
reviewed
May 24, 2021
packages/gatsby-plugin-gatsby-cloud/src/build-headers-program.js
Outdated
Show resolved
Hide resolved
wardpeet
approved these changes
May 25, 2021
LekoArts
pushed a commit
that referenced
this pull request
May 27, 2021
…to loop over pages (#31547) (#31606) * fix(gatsby): add componentChunkName to components list so don't need to loop over pages * fix type * fix tests * more fixes * Guard against null values (cherry picked from commit 783b937) Co-authored-by: Kyle Mathews <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps gatsby-plugin-gatsby-cloud avoid looping over all pages to get
componentChunkNames. This is slow plus it caused aMaximum call stack size exceedederror for sites with 100k+ pages.Fixes #31545