fix(gatsby-plugin-netlify): upgrade webpack-assets-manifest for compatibility with webpack@5

[pedrolamas]

Description

Some deprecation errors are showing from gatsby build when gatsby-plugin-netlify is in use, this fixes the problem by upgrading the webpack-assets-manifest version to the same used in the rest of gatsby codebase.

Related Issues

Fixes #29974

[kimbaudi]

@pedrolamas - did you run yarn jest gatsby-plugin-netlify afterwards? If so, you should have gotten an error (at least, it happened to me):

`TypeError: Cannot read property 'RawSource' of undefined

I guess what I'm trying to say is, you can't just upgrade webpack-assets-manifest from current version 3 to the latest version 5.

[pedrolamas]

@kimbaudi I did indeed, it passed perfectly on my end (tested under Windows 10)!

[kimbaudi]

@pedrolamas - I just tested after upgrading to "webpack-assets-manifest": "^5.0.1" and one of the tests are failing. I'm on Windows 10 also.

[pedrolamas]

@kimbaudi Can I ask you to checkout my branch, run git clean -x -d -f to remove all other files (please be aware this is like a new checkout of the repo, so all non-commited files will be removed!), and then run yarn bootstrap before running the tests again?

[kimbaudi]

@pedrolamas - ok I'll check out your branch and give it a shot. btw, you can shorten the command to git clean -xfd (i do this often 😄)

[pedrolamas]

Sorry @kimbaudi, I'm not a big git cli user, so I'm just copying the commands from Git Extensions! 😁

[kimbaudi]

@pedrolamas - I tested on your branch (and on my fork as well) and it works. I guess I did something wrong earlier. sorry about that

[pedrolamas]

For the record, I've tested this change locally with yalc and it worked fine for me (error messages are gone).

[sidharthachatterjee]

Thanks!

[1-800-jono]

@pedrolamas - did you run yarn jest gatsby-plugin-netlify afterwards? If so, you should have gotten an error (at least, it happened to me):

`TypeError: Cannot read property 'RawSource' of undefined

I guess what I'm trying to say is, you can't just upgrade webpack-assets-manifest from current version 3 to the latest version 5.

I just upgraded Gatsby to v3.9.1 and gatsby-plugin-netlify v3.9.0 and getting this same error.

[1-800-jono]

Never mind - fixed by running npm cache clean --force as a last resort.