Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move peerdeps to 16.9.0 & 17+ for react & react-dom #29735

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Move peerdeps to 16.9.0 & 17+ for react & react-dom #29735

merged 4 commits into from
Feb 26, 2021

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Feb 24, 2021 •
edited
Loading

Description

Upgrade peerdeps to the correct versions

Related Issues

[ch22641]

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 24, 2021
@wardpeet wardpeet marked this pull request as ready for review February 26, 2021 06:09
@LekoArts LekoArts added type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 26, 2021
@LekoArts
Copy link
Contributor

Why did you sometimes chose ^16.9.0 and sometimes ^16.9.0 || ^17.0.0? Shouldn't it always be ^16.9.0 || ^17.0.0?

vladar
vladar previously approved these changes Feb 26, 2021
View reviewed changes
wardpeet
wardpeet commented Feb 26, 2021
View reviewed changes
Copy link
Contributor Author

@wardpeet wardpeet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably the regex I used @LekoArts - updated it

@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Feb 26, 2021
@vladar vladar merged commit 6b86b99 into master Feb 26, 2021
@vladar vladar deleted the v3/upgrade-react branch February 26, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladar vladar vladar approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes type: maintenance An issue or pull request describing a change that isn't a bug, feature or documentation change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wardpeet @LekoArts @vladar