Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

contentful <3 gatsby v3 #29675

Merged
merged 4 commits into from
Mar 10, 2021
Merged

contentful <3 gatsby v3 #29675

merged 4 commits into from
Mar 10, 2021

Conversation

axe312ger
Copy link
Collaborator

A number of small code style / refactoring changes to get rid of a bunch of warnings (from deprecations) in Gatsby v3

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Feb 22, 2021
@axe312ger axe312ger added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Feb 22, 2021
wardpeet
wardpeet reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

packages/gatsby-source-contentful/src/gatsby-node.js Outdated Show resolved Hide resolved
@axe312ger axe312ger marked this pull request as ready for review March 8, 2021 14:46
@axe312ger axe312ger added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Mar 8, 2021
@pieh pieh mentioned this pull request Mar 10, 2021
Closed
@pieh pieh merged commit bce0b21 into master Mar 10, 2021
@pieh pieh deleted the refactor/contentful-gatsby-v3 branch March 10, 2021 16:42
@gatsbybot gatsbybot mentioned this pull request Mar 10, 2021
Merged
vladar pushed a commit that referenced this pull request Mar 10, 2021
@axe312ger @vladar
contentful <3 gatsby v3 (#29675)
0932e9e 
* refactor(graphql): migrate to new interface inheritance syntax

* refactor: pass whole nodes when touching for keep alive

* use getNode syntax

Co-authored-by: gatsbybot <[email protected]>
(cherry picked from commit bce0b21)
vladar pushed a commit that referenced this pull request Mar 10, 2021
@axe312ger
contentful <3 gatsby v3 (#29675) (#30173)
0331c51 
* refactor(graphql): migrate to new interface inheritance syntax

* refactor: pass whole nodes when touching for keep alive

* use getNode syntax

Co-authored-by: gatsbybot <[email protected]>
(cherry picked from commit bce0b21)

Co-authored-by: Benedikt Rötsch <[email protected]>
@vladar
Copy link
Contributor

vladar commented Mar 10, 2021

Published in [email protected]

@bnbabu55
Copy link

Published in [email protected]

@vladar I am facing the same issue with gatsby-source-wordpress plugin 5.0.0, any help would be appreciated.

This was referenced Mar 16, 2021
Closed
Merged
Closed
Closed
Merged
Closed
Merged
This was referenced Mar 17, 2021
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet left review comments

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@axe312ger @vladar @bnbabu55 @ascorbic @wardpeet @pieh