fix: Update plugin schema testing util and associated tests #27574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 19, 2020 12:06
gatsbot
bot
added
the
status: triage needed
laurieontech
added
topic: plugins
wardpeet
changed the title
mxstbr
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin schema testing util was using separate functionality causing a diff between valid schemas and those that passed tests. This PR updates the testing util to use our production validation function and makes all existing tests compatible with this change.
Note it also includes an addition to the gatsby-plugin-typescript schema that was the reason this was uncovered.
[ch17569]