[Tracking]: gatsby-image PRs waiting on review and merge #25487
Labels
status: needs core review
Currently awaiting review from Core team member
topic: media
Related to gatsby-plugin-image, or general image/media processing topics
type: maintenance
An issue or pull request describing a change that isn't a bug, feature or documentation change
type: question or discussion
Issue discussing or asking a question about Gatsby
As these are starting to pile up and age, I created this issue to keep track of them.
I've tried reaching out several times for review to my PRs, and I've reviewed several others related to
gatsby-image
. @wardpeet is assigned to most, but seems to be rather busy lately with other work. I'd appreciate it if someone could spare the time to give these a look, especially #25325Cheers.
Approved
I've reviewed these and would like to seem them merged.
Update: @wardpeet has reviewed and approved each one, two have been left unmerged however, would be great if someone with authority could merge those!
Pending changes
About a month since last activity, few days ago I reviewed and requested changes. If no activity after a while I'm happy to make the changes and recreate the PR, albeit waiting on core team about decision with how to approach ReactDOMServer. @pieh received no response since April 18.
Update: No feedback on this PR for 2 weeks since my activity there. I guess the
ReactDOMServer
approach isn't worth the time vs handling it with the v3 update where min React version can be raised.Update: @wardpeet decided against merging this. I still disagree with that decision and suggested workaround, but that discussion appears to have stalled.
Personal PRs awaiting review
image
#24811 - fix(gatsby-image): React hydration buster onimage
Several users are waiting on a fix for the hydration issue, while the base64 one is mostly docs so the feature can be actually discovered.
Update: Both have had an initial pass from @wardpeet but will need another review for changes, especially the hydration fix which added related fixes to art direction(I could separate these out into individual PRs if preferred).
The text was updated successfully, but these errors were encountered: