Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-netlify): Fix heuristic for appending redirects #23743

Merged
merged 1 commit into from
May 4, 2020
Merged

fix(gatsby-plugin-netlify): Fix heuristic for appending redirects #23743

merged 1 commit into from
May 4, 2020

Conversation

sidharthachatterjee
Copy link
Contributor

Currently if the _redirects file includes the header comment, we overwrite it without accounting for any static redirects added by the static folder in Gatsby

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner May 4, 2020 14:58
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 4, 2020
@sidharthachatterjee sidharthachatterjee added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 4, 2020
@gatsbybot gatsbybot merged commit ff0f7cf into master May 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/netlify-redirects branch May 4, 2020 15:28
@sidharthachatterjee
Copy link
Contributor Author

Published in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascorbic ascorbic ascorbic approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sidharthachatterjee @ascorbic @gatsbybot