Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-plugin-netlify): security headers merging #17538

Merged
merged 1 commit into from
Sep 10, 2019
Merged

fix(gatsby-plugin-netlify): security headers merging #17538

merged 1 commit into from
Sep 10, 2019

Conversation

antoinerousseau
Copy link
Contributor

@antoinerousseau antoinerousseau commented Sep 10, 2019 •
edited
Loading

Description

This PR allows writing security headers that override the default ones, instead of being prepended to them.

Related Issues

Fixes #8020.

@antoinerousseau antoinerousseau requested a review from a team as a code owner September 10, 2019 20:26
@antoinerousseau antoinerousseau mentioned this pull request Sep 10, 2019
Closed
sidharthachatterjee
sidharthachatterjee approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sidharthachatterjee sidharthachatterjee changed the title fix(gatsby-plugin-netlify) security headers merging fix(gatsby-plugin-netlify): security headers merging Sep 10, 2019
@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Sep 10, 2019
@gatsbybot gatsbybot merged commit 8420626 into gatsbyjs:master Sep 10, 2019
@antoinerousseau antoinerousseau deleted the fix/netlify-headers branch September 13, 2019 10:31
LOLdevelopr pushed a commit to LOLdevelopr/gatsby-1 that referenced this pull request Sep 21, 2019
@antoinerousseau @LOLdevelopr
fix(gatsby-plugin-netlify): security headers merging (gatsbyjs#17538)
fb7a3fd
@antoinerousseau antoinerousseau mentioned this pull request Oct 5, 2019
Merged
@wardpeet wardpeet mentioned this pull request Oct 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-netlify] Overwrite headers
3 participants
@antoinerousseau @sidharthachatterjee @gatsbybot