Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-netlify): Add caching headers for immutable assets #14000

Merged
merged 4 commits into from
May 14, 2019

Conversation

cameron-martin
Copy link
Contributor

Description

This PR adds long-term caching headers to the _headers file for any js files that have a hash in their filename. These are only added if the existing mergeCachingHeaders setting is enabled.

Related Issues

Fixes #13902.

@wardpeet
Copy link
Contributor

This looks awesome! This is great for our netlify users, it will increase speed for many regular visitors.

I'm checking to make sure it all works 👌

@wardpeet wardpeet self-assigned this May 13, 2019
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will enable faster gatsby sites on netlify 💪

@wardpeet wardpeet changed the title [gatsby-plugin-netlify]: Add caching headers for immutable assets feat(gatsby-plugin-netlify): Add caching headers for immutable assets May 14, 2019
@wardpeet wardpeet merged commit e5a4c3d into gatsbyjs:master May 14, 2019
@gatsbot
Copy link

gatsbot bot commented May 14, 2019

Holy buckets, @cameron-martin — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@wardpeet
Copy link
Contributor

published in [email protected] 🎉

@cameron-martin cameron-martin deleted the netlify-caching-headers branch May 14, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-netlify]: Caching headers missing for many immutable assets.
2 participants