fix(gatsby-link): provide fallback for __BASE_PATH__ being missing #13839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published as [email protected] (and [email protected]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a regression identified by the inimitable @m-allanson--specifically that
__BASE_PATH__won't be defined in older versions of gatsby, and older versions of gatsby use a^for dependencies, therefore they'd be using this version.This would have been remediated with a lockfile, but nice not to break anyone needlessly.
As such--this introduces a guard using
typeofto detect the existence of__BASE_PATH__. If it's not defined, it'll fallback to the "legacy"__PATH_PREFIX__.Related Issues
Fixes #13836