fix(gatsby-plugin-sitemap): include path prefix #12852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include path prefix in the index sitemap created by gatsby-plugin-sitemap.
|
@gatsbyjs/core is there any chance someone can take a look at this? |
pieh
reviewed
Mar 27, 2019
wardpeet
approved these changes
Mar 27, 2019
pieh
reviewed
Mar 27, 2019
| } | ||
| const prefix = `/test` | ||
| await onPostBuild({ graphql, pathPrefix: prefix }, options) | ||
| expect(sitemapSpy.mock.calls[0][0].hostname).toEqual( |
There was a problem hiding this comment.
NIT: don't need to change this (we do use it in different places as well), but for future, please use
expect(sitemapSpy).toBeCalledWith(
expect.objectContaining({
hostname: `${queryResult.data.site.siteMetadata.siteUrl}${prefix}`
})
)reaching to .mock.calls[0][0] works, but is less readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Gatsby sitemap plugin can be configured to split up all of the sites URLs into smaller sitemaps, all being referenced from a main "index" sitemap. Unfortunately, this index sitemap doesn't take the
pathPrefixoption into account and will never link to the correct "child" sitemaps.As
sitemap.jsdoesn't have an option forpathPrefix, this change appends thepathPrefixto the site'shostnamewhen more than one sitemap needs to be created.