Bring back preview sites when creating a pull request

[wardpeet]

Description

We used to have demo sites added to PRs so we can view our changes and make sure they didn't break.

I find it super valuable for www when changes are done to docs or parts of core that we can visualize it without building www yourself #10815 and #7348 will help too.

Besides www we could link plugins to examples and tell gatsbybot about these deploys so we don't have to clutter the comments with 100 deploys.

I've noticed that builds are running on netlify but just have to bring the bot back.

Steps to reproduce

Go to pull requests, pick one from the last month and you'll see no deploy comments :'(

Expected result

What should happen?

[gurpreet-hanjra]

Hello @wardpeet this issue seems interesting. Would you mind giving some pointers to fix this? Thank you.

[pieh]

We removed Netlify github app from repo because it was too spammy and also netlify check in PR status check was confusing because example sites were overriding this check.

Deploys can still be manually checked when visiting f.e. https://app.netlify.com/sites/using-remark/deploys (this should visible to everyone).

Ideally we would have have single "example sites" check that would create detailed view in "Checks" tab on PRs that would list status for each example, but this require some custom coding.

[m-allanson]

Thanks @gurpreet-hanjra! Unfortunately this needs to be done by a Gatsby team member, as it requires access to Gatsby's Netlify account.

@pieh Is the new Netlify GitHub App considerate with notifications? Or is the problem that we were pushing notifications from multiple sites to this one repo? https://www.netlify.com/blog/2018/12/03/richer-github-integrations-come-to-netlify-thanks-to-github-apps/

I think it'd at least be worth re-adding netlify build notifications for gatsbyjs.org, even if we don't add all the example. site notifications back.

Ideally we would have have single "example sites" check that would create detailed view in "Checks" tab on PRs that would list status for each example, but this require some custom coding.

👍

[wardpeet]

@pieh so making a mini dashboard where all example sites are shown?

I can imagine the spammyness when using a bot when it builds on each push. If multiple netlify apps are possible this would fix it too? (like circle-ci)

[pieh]

@pieh Is the new Netlify GitHub App considerate with notifications? Or is the problem that we were pushing notifications from multiple sites to this one repo? netlify.com/blog/2018/12/03/richer-github-integrations-come-to-netlify-thanks-to-github-apps

So this is what we've seen when I re-enabled netlify app for a moment

There were multiple extra checks added by netlify (comming from "richer github integration") - this can be disabled per site on netlify settings, but I don't have access to all of them and it wasn't priority task to do.

I mean all of this (comments, checks) should be configurable, but we still won't really get nice list of results for each example in single unified manner.

[gatsbot]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

Thanks for being a part of the Gatsby community! 💪💜

[gatsbot]

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

Thanks again for being part of the Gatsby community!