Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gatsby-source-shopify2 and gatsby-source-shopify #10773

Closed
sidharthachatterjee opened this issue Jan 2, 2019 · 4 comments
Closed

Merge gatsby-source-shopify2 and gatsby-source-shopify #10773

sidharthachatterjee opened this issue Jan 2, 2019 · 4 comments

Comments

@sidharthachatterjee
Copy link
Contributor

gatsby-source-shopify2 seems to have some fixes to gatsby-source-shopify

Note: This is based on the original plugin along with major fixes for localFile property of images and Gatsby V2.

@nikhilag Would you be interested in opening a pull request with those fixes back into gatsby-source-shopify?

Related issue at #10711

@jserrao
Copy link
Contributor

jserrao commented Jan 4, 2019

I've been trying to get some movement on the original maintainer of gatsby-source-shopify for months, might be quasi-abandoned at this point.

@witbybit
Copy link

witbybit commented Jan 4, 2019

@sidharthachatterjee All my fixes have already been pulled into gatsby-source-shopify. See angeloashmore/gatsby-source-shopify@ef0ac1a .
There were more changes afterwards and then it was moved to gatsby core. Not sure why it's not working as per #10711 given that you already verified the plugin works fine.

@witbybit
Copy link

@sidharthachatterjee The new version of gatsby-source-shopify should work properly now. See this change - #10955
I will be deprecating my plugin.

@sidharthachatterjee
Copy link
Contributor Author

Thanks for the clarity, @nikhilag

Closing this issue now since gatsby-source-shopify2 is now deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants