Entire URL gets suffixed to redirect key

[jariz]

@gburgett @JoshuaWalsh
I don't fully understand what's happening here or why it's needed:

https://github.com/jariz/gatsby-plugin-s3/blob/a8705502d0f71cacaabc2d2a87e2464e16df616e/src/gatsby-node.ts#L114-L120

This seems rather unnecessary because S3 will already prepend the url if a hostname+protocol is provided (that's the whole reason why we provide these fields to the routingrules), we do not need to do that ourselves.

I'm fairly sure this is what's causing the domain to get prepended twice for me right now.
Downgrading to 0.2.3 fixes it.

curl -I -L https://[domain]/l/craft-cms

HTTP/2 301
content-length: 0
location: https://[domain]/[domain]/techniek/craft-cms

HTTP/2 404
content-length: 0
x-amz-error-code: NoSuchKey
x-amz-error-message: The specified key does not exist.
x-amz-error-detail-key: https://[domain]/[domain]/techniek/craft-cms

[YoshiWalsh]

Damn, sorry for letting that one slip through. That block is only necessary for when generateRedirectObjectsForPermanentRedirects is enabled. Moving it to within this if statement should fix the problem, although moving the logic into here might be cleaner.

I'm not sure how I missed this in testing, since protocol/hostname are features I use myself. I must not have been thorough enough when testing with generateRedirectObjectsForPermanentRedirects disabled, sorry.

[YoshiWalsh]

Working on a fix now.