-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshifaw
commented
Dec 3, 2019
•
edited
Loading
edited
- Updated haplotypecaller to WDL 1.0, removed comments from haplotypecaller JSON
- Added allele-specific annotations to HC
- Replaced joint-discovery with JointGenotyping workflow,
- Added Terra version for JointGenotyping workflow
- Added urls for imports for JointGenotyping workflows
- Updated ReadMe to reflect changes to JointGenotyping workflow
…s-indels into dev
…s-indels into dev
* added updated joint-discovery wdl, needs testing * Added place holder for terra verion of JointGenotyping wdl * Replaced joint-discovery with JointGenotyping workflow, added place holders for terra version for JointGenotyping workflow * updated the terra version of the JointGenotyping * added urls for imports for JointGenotyping workflows * Updated ReadMe
* added updated joint-discovery wdl, needs testing * Added place holder for terra verion of JointGenotyping wdl * Replaced joint-discovery with JointGenotyping workflow, added place holders for terra version for JointGenotyping workflow * updated the terra version of the JointGenotyping * added urls for imports for JointGenotyping workflows * Updated ReadMe * added missing runtime variables * added missing runtime variable
* added updated joint-discovery wdl, needs testing * Added place holder for terra verion of JointGenotyping wdl * Replaced joint-discovery with JointGenotyping workflow, added place holders for terra version for JointGenotyping workflow * updated the terra version of the JointGenotyping * added urls for imports for JointGenotyping workflows * Updated ReadMe * added missing runtime variables * added missing runtime variable
bshifaw
commented
Dec 3, 2019
bshifaw
commented
Dec 3, 2019
* added updated joint-discovery wdl, needs testing * Added place holder for terra verion of JointGenotyping wdl * Replaced joint-discovery with JointGenotyping workflow, added place holders for terra version for JointGenotyping workflow * updated the terra version of the JointGenotyping * added urls for imports for JointGenotyping workflows * Updated ReadMe * added missing runtime variables * added missing runtime variable * added recent updates from dsde-pipelines repo to terra version
ldgauthier
requested changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some additional updates to the joint genotyping caveats and minor comments.
ldgauthier
reviewed
Jan 9, 2020
ldgauthier
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the HC workflow updated with AS annotations you can merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.