Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ES5+Modules dist #32

Open
garycourt opened this issue May 25, 2018 · 3 comments
Open

Create ES5+Modules dist #32

garycourt opened this issue May 25, 2018 · 3 comments

Comments

@garycourt
Copy link
Owner

In order to support the modules property in package.json, an ES5 version of uri-js using ES6 Modules needs to be compiled.
@murphyke
Copy link

murphyke commented Jun 5, 2018

There will be much rejoicing. My create-react-app app started failing to build when I added a dependent of uri-js ....

@garycourt
Copy link
Owner Author

Use uri-js@^4.2.2 for the time being, as that version doesn't have the modules property in package.json.

@murphyke
Copy link

murphyke commented Jun 6, 2018

Thanks, I forgot that I had just started using package-lock.json, and I had assumed that my CI/CD build was using the latest version. It's working now, obviously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garycourt @murphyke