Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/backstop 6.3.x #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dgrebb
Copy link

@dgrebb dgrebb commented Jan 31, 2024

Update with dependency on backstopjs@^6.3.3 and bump to debug@^4.3.4

Tested with npm and pnpm, which was referenced in #86.

Show Ember Test Runs

From #87

Summary

This is a general refresh PR, which sets the project up for Node 20 support in a forthcoming BackstopJS release.

Details

  • configure .eslintrc.js to use ecmaVersion: 2020
  • general eslint formatting adjustments with the latest rules
    • adds eslint-disable where necessary
  • updates addon-test-support/index.js export — this was not working with ember-cli@^5.4.0, or perhaps @ember-test-helpers@^3.2.0
  • specify "type": "commonjs" in package.json
  • update all the things

General Testing Performed

  • ember install ember-backstop
  • ember generate acceptance-test home-test
  • File: tests/acceptance/home-test.js Line 3: import backstop from 'ember-backstop/test-support/backstop';
  • File: tests/acceptance/home-test.js
    15:   test('it renders the thing', async function (assert) {
    16:     await visit('/');
    17:     await backstop(assert);
    18:     assert.dom('#ember-welcome-page-id-selector').exists();
    19:   });
- ✓ `ember serve`
- ✓ `ember backstop-remote`
- ✓ `ember test`
- ✓ verified running tests/screen shots in:
  - http://localhost:4200/tests
  - http://localhost:3000/backstop_data/html_report/index.html
- ✓ `ember backstop-stop`

@dgrebb
Copy link
Author

dgrebb commented Jan 31, 2024

@garris this PR sets dependencies.backstopjs to "^6.3.3 and bumps debug to "^4.3.4", but includes everything in #87 as well.

@villander
Copy link

@garris would you need any help to merge and release it?

@garris
Copy link
Owner

garris commented Mar 19, 2024

@villander Actually yes. It took a while to get 6.3.x stable-- would be great to get this done now that we're stable on the backstop side!

If you could bump backstop to latest and get a clean test I would gladly pull it in.

Please let me know if you need anything else from me.

Cheers

@villander
Copy link

@garris is there any CI in this repo? would be great to have the ember tests running here. I'll test this branch with my app and get back to you.

@garris
Copy link
Owner

garris commented Mar 26, 2024

Hi @villander -- unfortunately no CI tests yet -- would be great to set that up. That said, this project is in maintenance mode at this point -- not anticipating any major contributions. But if you add some CI tests I will add it to the GH actions section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants