Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support For Connecting to Docker Hosted Backstop Server #47

Open
jkusa opened this issue Jun 23, 2020 · 1 comment
Open

Add Support For Connecting to Docker Hosted Backstop Server #47

jkusa opened this issue Jun 23, 2020 · 1 comment

Comments

@jkusa
Copy link
Contributor

jkusa commented Jun 23, 2020

Currently, ember-backstop expects to connect to a backstop server connected on the same host as the test host. It would be really useful to have a docker based renderer server for consistent verification across dev machines and CI.

I was able to prototype this by running the backstop docker image and mounting port 3000 to local 3000. After that I needed to update the origin field in the fetch request to the following:

Current:

Modified:

origin: `http://host.docker.internal:${new URL(ORIGIN).port}`

This is obviously a POC/hack, but it would be great to have first class support for connecting to a docker based server.

@garris
Copy link
Owner

garris commented Jun 24, 2020

This is totally right on. Both of these concepts are something I would love to see implemented.

  1. ability to hit a remote backstop (or better yet -- enable backstop to hit a remote chrome -- see Allow using remote Chrome with puppeteer BackstopJS#1002 )
  2. add a CLI param to override host and port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants