Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated signals in lablgtk3 (expose & set_scroll_adjustments) #124

Closed
vrotaru opened this issue Apr 1, 2021 · 1 comment
Closed

Deprecated signals in lablgtk3 (expose & set_scroll_adjustments) #124

vrotaru opened this issue Apr 1, 2021 · 1 comment

Comments

@vrotaru
Copy link

vrotaru commented Apr 1, 2021

The "expose" and "set_scroll_adjustments" signals are deprecated in GTK-3.0 but are still present in lablgtk3

One such place is GText.view class. Another, but related problem is the text view does not have the GtkScrollable interface methods, while the GtkTextView implements the above interface.

My guess is that those methods should be added to GText.view

  method hadjustment : GData.adjustment
  method vadjustment : GData.adjustment

  method set_hadjustment : GData.adjustment -> unit
  method set_vadjustment : GData.adjustment -> unit

A proof of concept patch is here with the usual disclaimer: "Works on my machine"

@vrotaru
Copy link
Author

vrotaru commented Aug 7, 2021

Looks like it was fixed in this PR: 5cc0f7e

So, unless someone intends to do more work on this, like adding scrollable abstract class from which various widget will inherit, this can be closed.

@vrotaru vrotaru closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant