Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create metrics for labels from machinedeployments and machineclasses #443

Closed
supreethrao opened this issue Apr 14, 2020 · 2 comments
Closed
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)

Comments

@supreethrao
Copy link

What would you like to be added:
machine controller manager provides useful metrics around machine deployments. However, it will be useful to also have metrics for labels on the custom resources. The labels can have useful information like the version of the resource amongst others and would hence be useful to have them as metrics, similar to kube-state-metrics for k8s resources.

Why is this needed:
Serves different purposes. Some of the reasons could be

  1. Having the information from labels (e.g version) displayed on a status dashboard
  2. In alerting if machine deployments across different AZs are not the same

I am happy to work on this and add this feature if deemed useful

@supreethrao supreethrao added the kind/enhancement Enhancement, improvement, extension label Apr 14, 2020
@hardikdr
Copy link
Member

Thanks @supreethrao for suggesting it. Please feel free to pick this up.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Jun 14, 2020
@prashanth26 prashanth26 added area/monitoring Monitoring (including availability monitoring and alerting) related and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Aug 16, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 16, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Dec 16, 2020
@prashanth26
Copy link
Contributor

Close in favour of #211 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage)
Projects
None yet
Development

No branches or pull requests

4 participants