From 872d1e428a09a63b9dadedf9e530b2aede8def24 Mon Sep 17 00:00:00 2001 From: vpnachev Date: Fri, 2 Jun 2023 13:58:52 +0300 Subject: [PATCH 1/2] Remove temporary code cleaning MR heathcheck --- pkg/controller/healthcheck/add.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/controller/healthcheck/add.go b/pkg/controller/healthcheck/add.go index 5379ea46..85c4c180 100644 --- a/pkg/controller/healthcheck/add.go +++ b/pkg/controller/healthcheck/add.go @@ -45,8 +45,7 @@ func RegisterHealthChecks(mgr manager.Manager, opts healthcheck.DefaultAddArgs) HealthCheck: general.CheckManagedResource(constants.ManagedResourceNamesSeed), }, }, - // TODO(shafeeqes): Remove this condition in a future version. - sets.New(gardencorev1beta1.ShootSystemComponentsHealthy), + sets.New[gardencorev1beta1.ConditionType](), ) } From a48adc17ca43eb11c114c3f62ef8f43c8baa2dfe Mon Sep 17 00:00:00 2001 From: vpnachev Date: Fri, 2 Jun 2023 14:02:56 +0300 Subject: [PATCH 2/2] Register healthcheck for the shoot's managedresource --- pkg/controller/healthcheck/add.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkg/controller/healthcheck/add.go b/pkg/controller/healthcheck/add.go index 85c4c180..e24bf14c 100644 --- a/pkg/controller/healthcheck/add.go +++ b/pkg/controller/healthcheck/add.go @@ -44,6 +44,10 @@ func RegisterHealthChecks(mgr manager.Manager, opts healthcheck.DefaultAddArgs) ConditionType: string(gardencorev1beta1.ShootControlPlaneHealthy), HealthCheck: general.CheckManagedResource(constants.ManagedResourceNamesSeed), }, + { + ConditionType: string(gardencorev1beta1.ShootSystemComponentsHealthy), + HealthCheck: general.CheckManagedResource(constants.ManagedResourceNamesShoot), + }, }, sets.New[gardencorev1beta1.ConditionType](), )