Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Azure Stack Hub #470

Open
christianhuening opened this issue Mar 31, 2022 · 2 comments
Open

Add Support for Azure Stack Hub #470

christianhuening opened this issue Mar 31, 2022 · 2 comments
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/azure Microsoft Azure platform/infrastructure

Comments

@christianhuening
Copy link

How to categorize this issue?

/area control-plane
/kind enhancement
/platform azure

What would you like to be added:
I would like to get support for Azure Stack environments added to the Azure Provider.

Why is this needed:
We have a customer which requires us to use Azure Stack Hub.

In general the support is present in the upstream cloud-provider for azure: https://kubernetes-sigs.github.io/cloud-provider-azure/install/configs/#azure-stack-configuration

The required config values are still hard-coded though in the current extension: https://github.com/gardener/gardener-extension-provider-azure/blob/master/charts/internal/cloud-provider-config/templates/cloud-provider-config.tpl#L2

I am currently trying to figure out the exact work needed to be done. Any help to figure this out, would be greatly appreciated. We're either up to open a PR ourselves but maybe would also be willing to fund this feature if anybody would be willing to work on this short-term.

@christianhuening christianhuening added the kind/enhancement Enhancement, improvement, extension label Mar 31, 2022
@gardener-robot gardener-robot added area/control-plane Control plane related platform/azure Microsoft Azure platform/infrastructure labels Mar 31, 2022
@dkistner
Copy link
Member

dkistner commented Apr 5, 2022

Hi @christianhuening,

beside general questions how to run Gardener in a private environment like Azure Stack (e.g. dns, container image registry, cert management...), there will be indeed also some Azure specific adaptions required.

You checked already that the Azure k8s cloud provider support Azure Stack. That's good, then the Azure ccm will most likely work with AzureStack and we just need to configure it properly via the extension here.

In addition I see following other tasks (not sure if the list is complete, some more detailed research would be required).

  • The Infrastructure controller / Terraform manifest need to be adopted to support the AzureStack environment.
  • Native go-sdk Azure clients used in the backupbucket, backupentry, bastion, dnsrecord and worker controllers need to be adopted to support the AzureStack environment ref.
  • The controlplane controller need to generate the adopted configuration for ccm and csi drivers to support Azure Stack, ref.
  • The machine-controller-manager-provider-azure need to be adopted to support AzureStack. Currently the Azure environment is hardcoded ref. I guess the Azure environment should be passed into the respective MachineClass resources that are generated by the worker controller ref.

That's the obvious things that come into my mind. Unfortunately we have currently no capacity to do active development in this direction, but I would be glad to answer questions if you want to pick up the task.

@christianhuening
Copy link
Author

Thanks @dkistner ! With that analysis we'll be re-evaluating whether we will attempt this now, especially since there appears not to be too much interest by others and the question of mid-term maintenance is present. We might reside to the vSphere provider for the current project instead.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Oct 3, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/azure Microsoft Azure platform/infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants