Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deletion of not yet reconciled zones #231

Open
timebertt opened this issue Nov 30, 2020 · 0 comments
Open

Allow deletion of not yet reconciled zones #231

timebertt opened this issue Nov 30, 2020 · 0 comments
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/aws Amazon web services platform/infrastructure

Comments

@timebertt
Copy link
Member

How to categorize this issue?

/area usability
/kind enhancement
/priority normal
/platform aws

What would you like to be added:

Currently, validator-aws forbids removal of zones from a Shoot's infrastructureConfig / workers[].zones.
This is, because it can't know

  • a) if the resources for those removed zones (subnet, security groups, etc.) have already been created
    • but if they haven't been created yet, it would actually be safe to remove a zone
  • b) if a removed zone is empty and can be deleted safely (no machines/other resources left in subnet/zone)

We would like to lift restriction a) and allow removal of zones, that have not been created yet.
This would require that the infrastructure actuator reports back to the garden cluster, what resources (e.g. subnets) have been created for a given Infrastructure object.

Why is this needed:

This will allow endusers to help themselves and fix a broken Shoot spec, for example when they try to add a zones with a CIDR that conflicts with another existing subnet in the VPC. In that case, the addition of the zone succeeds, but the infrastructure reconciliation will fail and the Shoot will be in Failed state, but the zone cannot be removed, although it is "empty" and could be removed safely.

@timebertt timebertt added the kind/enhancement Enhancement, improvement, extension label Nov 30, 2020
@gardener-robot gardener-robot added area/usability Usability related platform/aws Amazon web services platform/infrastructure priority/normal labels Nov 30, 2020
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Sep 22, 2021
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) platform/aws Amazon web services platform/infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants