Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the EBS CSI driver configurable #159

Closed
hardikdr opened this issue Aug 10, 2020 · 5 comments · Fixed by #164
Closed

Make the EBS CSI driver configurable #159

hardikdr opened this issue Aug 10, 2020 · 5 comments · Fixed by #164
Assignees
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension status/in-progress Issue is in progress/work topology/shoot Affects Shoot clusters

Comments

@hardikdr
Copy link
Member

hardikdr commented Aug 10, 2020

How to categorize this issue?

/area usability
/kind enhancement
/priority normal

What would you like to be added: The EBS CSI driver v0.6.0 has been released recently. It contains the changes, allowing users to overwrite the max-attachable-volumes per node for the cluster.

We need to enable both a new version of CSI-driver and users to be able to configure the volume-attach-limit flag of the csi-driver via shoot-resource.

To mention, this is part of the issue gardener/gardener#2354 , and a prominent need for the MemoryOne integration to work at its best with k8s 1.18+.

Why is this needed: The environment variable KUBE_MAX_PD_VOLS is ineffective with CSI migration, which leaves no way for a user to configure the max-attachable-volumes.

@hardikdr
Copy link
Member Author

cc @rfranzke

@rfranzke rfranzke transferred this issue from gardener/gardener Aug 10, 2020
@gardener-robot gardener-robot added area/usability Usability related kind/enhancement Enhancement, improvement, extension priority/normal labels Aug 10, 2020
@ialidzhikov
Copy link
Member

/assign @ialidzhikov

@rfranzke
Copy link
Member

/topology shoot
/in-progress

The idea is that the end-user can configure the volume attach limit by the following annotation on the shoot: aws.provider.extensions.gardener.cloud/volume-attach-limit: "42".
The AWS control plane extension can read this information from the Cluster resource and configure the CSI driver in the shoot properly.

@gardener-robot gardener-robot added status/in-progress Issue is in progress/work topology/shoot Affects Shoot clusters labels Aug 10, 2020
@ialidzhikov
Copy link
Member

ialidzhikov commented Aug 11, 2020

The idea is that the end-user can configure the volume attach limit by the following annotation on the shoot: aws.provider.extensions.gardener.cloud/volume-attach-limit: "42".
The AWS control plane extension can read this information from the Cluster resource and configure the CSI driver in the shoot properly.

Currently the gardener-apiserver won't increase the metadata.generation hence Shoot won't be triggered for reconciliation when the annotation is newly added. Any ideas how to circumvent that? Annotation key matching in gardener-apiserver and increasing the generation when the annotation contains extensions.gardener.cloud? 😅

I will now propose PR for the v0.6.0 upgrade and a draft PR for the --volume-attach-limit handling.

@rfranzke
Copy link
Member

Well, I wouldn't do anything for now and simply state that the user can trigger the reconciliation using gardener.cloud/operation=reconcile annotation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/enhancement Enhancement, improvement, extension status/in-progress Issue is in progress/work topology/shoot Affects Shoot clusters
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants